Minor code cleanup in check_system_module #621
Conversation
Problem: Reading a file using `f.open().read()` keeps the file open until the garbage collector deletes the variable. Since this uses Pathlib already, using `Path(...).read_text()` is cleaner and does not depend on the opening mode being `r`. A file with no content could not be distinguished from a missing file. Instead, this changes the behaviour to return None when the file is missing instead of an empty string.
|
The PR is categorized as 'BLUE' because the changes are relatively small and focused. The PR only includes a few lines of code changes (130 out of 130) and these changes are related to the Highlighting:
This PR is likely to have minimal impact on the codebase and is unlikely to introduce new bugs. It is recommended to review this PR as soon as possible to ensure that it does not introduce any unexpected behavior. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 57.92% 57.92%
=======================================
Files 60 60
Lines 5402 5402
Branches 600 600
=======================================
Hits 3129 3129
Misses 2133 2133
Partials 140 140 ☔ View full report in Codecov by Sentry. |
Problem: Reading a file using
f.open().read()keeps the file open until the garbage collector deletes the variable.Since this uses Pathlib already, using
Path(...).read_text()is cleaner and does not depend on the opening mode beingr.A file with no content could not be distinguished from a missing file. Instead, this changes the behaviour to return None when the file is missing instead of an empty string.